fix: use full output-path on convert mdapi
#1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristiand391
commented
Jul 15, 2024
test/nuts/convert/mdapi.nut.ts
Outdated
| @@ -90,6 +90,10 @@ describe('project convert mdapi NUTs', () => { | |||
| expect(result.jsonOutput?.status).to.equal(0); | |||
| expect(result.jsonOutput?.result).to.be.an('array').with.length.greaterThan(10); | |||
| expect(fs.existsSync(convertedToSrcPath)).to.be.true; | |||
| expect(result.jsonOutput).to.not.be.undefined; | |||
| result.jsonOutput?.result.forEach((md) => { | |||
| expect(md.filePath.startsWith(convertedToSrcPath)).to.be.true; | |||
There was a problem hiding this comment.
This NUT was testing that the output dir was created in L92 (which is true) but the metadata was still written to the first dir in the path.
WillieRuemmele
approved these changes
Jul 18, 2024
QA Notesthe NUT should suffice... ✅ : validated source format was extracted to nested path from current |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix a bug where
project convert mdapi --output-dir path/to/outputwould save the converted metadata topathinstead ofpath/to/outputif the path didn't exist before.When the dir doesn't exist we create it for the user but the code was returning
fs.promises.mkdirresponse which only returned the first dir in the path:https://nodejs.org/api/fs.html#fspromisesmkdirpath-options
Updated convert NUT to check that the filepath starts with the full output path.
What issues does this PR fix or reference?
@W-15097291@